Skip to content

[O2B-1549] Migrate anchored simulation passes overview model to use filtering model pattern#2102

Closed
NarrowsProjects wants to merge 4 commits intoimprov/O2B-1548/Migrate-qcFlagTypesOverviewModel-to-use-FilteringModel-patternfrom
improv/O2B-1549/Migrate-AnchoredSimulationPassesOverviewModel-to-use-FilteringModel-pattern
Closed

[O2B-1549] Migrate anchored simulation passes overview model to use filtering model pattern#2102
NarrowsProjects wants to merge 4 commits intoimprov/O2B-1548/Migrate-qcFlagTypesOverviewModel-to-use-FilteringModel-patternfrom
improv/O2B-1549/Migrate-AnchoredSimulationPassesOverviewModel-to-use-FilteringModel-pattern

Conversation

@NarrowsProjects
Copy link
Collaborator

@NarrowsProjects NarrowsProjects commented Mar 10, 2026

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • None

Notable changes for developers:

  • The AnchoredSimulationPassOverviewModel file now stores its filter in a FilteringModel instance.
  • The names filter must now be accessed through the FilteringModel.get function

Changes made to the database:

@NarrowsProjects NarrowsProjects self-assigned this Mar 10, 2026
@codecov
Copy link

codecov bot commented Mar 10, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.84%. Comparing base (27a8bbc) to head (6fe055b).

Files with missing lines Patch % Lines
...dOverview/AnchoredSimulationPassesOverviewModel.js 0.00% 11 Missing ⚠️
...rview/SimulationPassesPerLhcPeriodOverviewModel.js 0.00% 11 Missing ⚠️
...ses/ActiveColumns/simulationPassesActiveColumns.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                                                Coverage Diff                                                 @@
##           improv/O2B-1548/Migrate-qcFlagTypesOverviewModel-to-use-FilteringModel-pattern    #2102      +/-   ##
==================================================================================================================
+ Coverage                                                                           45.83%   45.84%   +0.01%     
==================================================================================================================
  Files                                                                                1042     1042              
  Lines                                                                               17175    17171       -4     
  Branches                                                                             3105     3105              
==================================================================================================================
  Hits                                                                                 7872     7872              
+ Misses                                                                               9303     9299       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NarrowsProjects NarrowsProjects force-pushed the improv/O2B-1549/Migrate-AnchoredSimulationPassesOverviewModel-to-use-FilteringModel-pattern branch from 359d9d7 to 2f6fcf1 Compare March 10, 2026 09:31
@NarrowsProjects NarrowsProjects changed the title Improv/o2 b 1549/migrate anchored simulation passes overview model to use filtering model pattern [O2B-1549] Migrate anchored simulation passes overview model to use filtering model pattern Mar 10, 2026
@NarrowsProjects NarrowsProjects marked this pull request as draft March 10, 2026 09:41
@NarrowsProjects NarrowsProjects deleted the improv/O2B-1549/Migrate-AnchoredSimulationPassesOverviewModel-to-use-FilteringModel-pattern branch March 10, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graduta graduta Awaiting requested review from graduta graduta is a code owner

Assignees

@NarrowsProjects NarrowsProjects

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NarrowsProjects